Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2242324: exporter: avoid fetching performance metrics from mgr/prometheus #564

Open
wants to merge 1 commit into
base: release-4.14
Choose a base branch
from

Conversation

avanthakkar
Copy link

Avoid fetching performance counters of ceph daemons in prometheus module by setting exclude_perf_counters to true, given ceph-exporter takes of it in 4.14

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 1, 2024
Copy link

openshift-ci bot commented Feb 1, 2024

@avanthakkar: This pull request references Bugzilla bug 2242324, which is invalid:

  • expected the bug to target the "ODF 4.14.5" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2242324: avoid fetching performance metrics from mgr/prometheus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: avanthakkar
Once this PR has been reviewed and has the lgtm label, please assign travisn for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@avanthakkar avanthakkar force-pushed the disable-perf-counters-prometheus-module branch from ef0ea9f to 6f63d4c Compare February 1, 2024 14:18
Avoid fetching performance counters of ceph daemons in prometheus module
by setting `exclude_perf_counters` to true, given ceph-exporter takes of it in 4.14

Signed-off-by: Avan Thakkar <[email protected]>
@avanthakkar avanthakkar force-pushed the disable-perf-counters-prometheus-module branch from 6f63d4c to 0393483 Compare February 1, 2024 14:29
@avanthakkar avanthakkar changed the title Bug 2242324: avoid fetching performance metrics from mgr/prometheus Bug 2242324: exporter: avoid fetching performance metrics from mgr/prometheus Feb 1, 2024
@travisn
Copy link

travisn commented Feb 1, 2024

BZ 2242324 is for 4.13, so we will need a clone for merging this in 4.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants